Skip to content

Commit

Permalink
Delete unused LocalFrameViewLayoutContext's startDisallowingLayout an…
Browse files Browse the repository at this point in the history
…d endDisallowingLayout

https://bugs.webkit.org/show_bug.cgi?id=256630

Reviewed by Antti Koivisto.

Deleted the unused code.

* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::performLayout):
(WebCore::LocalFrameViewLayoutContext::canPerformLayout const):
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
(WebCore::LocalFrameViewLayoutContext::startDisallowingLayout): Deleted.
(WebCore::LocalFrameViewLayoutContext::endDisallowingLayout): Deleted.
(WebCore::LocalFrameViewLayoutContext::layoutDisallowed const): Deleted.

Canonical link: https://commits.webkit.org/263955@main
  • Loading branch information
rniwa committed May 11, 2023
1 parent 300c734 commit 51a237c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
3 changes: 0 additions & 3 deletions Source/WebCore/page/LocalFrameView.h
Original file line number Diff line number Diff line change
Expand Up @@ -443,9 +443,6 @@ class LocalFrameView final : public FrameView {

WEBCORE_EXPORT Color documentBackgroundColor() const;

void startDisallowingLayout() { layoutContext().startDisallowingLayout(); }
void endDisallowingLayout() { layoutContext().endDisallowingLayout(); }

static MonotonicTime currentPaintTimeStamp() { return sCurrentPaintTimeStamp; } // returns 0 if not painting

WEBCORE_EXPORT void updateLayoutAndStyleIfNeededRecursive();
Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/page/LocalFrameViewLayoutContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,6 @@ bool LocalFrameViewLayoutContext::canPerformLayout() const
if (isInRenderTreeLayout())
return false;

if (layoutDisallowed())
return false;

if (view().isPainting())
return false;

Expand Down
5 changes: 0 additions & 5 deletions Source/WebCore/page/LocalFrameViewLayoutContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ class LocalFrameViewLayoutContext {
void scheduleSubtreeLayout(RenderElement& layoutRoot);
void unscheduleLayout();

void startDisallowingLayout() { ++m_layoutDisallowedCount; }
void endDisallowingLayout() { ASSERT(m_layoutDisallowedCount > 0); --m_layoutDisallowedCount; }

void disableSetNeedsLayout();
void enableSetNeedsLayout();

Expand Down Expand Up @@ -125,7 +122,6 @@ class LocalFrameViewLayoutContext {

void performLayout();
bool canPerformLayout() const;
bool layoutDisallowed() const { return m_layoutDisallowedCount; }
bool isLayoutSchedulingEnabled() const { return m_layoutSchedulingIsEnabled; }

void layoutTimerFired();
Expand Down Expand Up @@ -176,7 +172,6 @@ class LocalFrameViewLayoutContext {
LayoutNestedState m_layoutNestedState { LayoutNestedState::NotInLayout };
unsigned m_layoutCount { 0 };
unsigned m_disableSetNeedsLayoutCount { 0 };
int m_layoutDisallowedCount { 0 };
unsigned m_paintOffsetCacheDisableCount { 0 };
LayoutStateStack m_layoutStateStack;
std::unique_ptr<Layout::LayoutTree> m_layoutTree;
Expand Down

0 comments on commit 51a237c

Please sign in to comment.