Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Page reload loop when conditional mediation fails #73

Open
Kehrlann opened this issue Oct 15, 2024 · 0 comments
Open

Page reload loop when conditional mediation fails #73

Kehrlann opened this issue Oct 15, 2024 · 0 comments

Comments

@Kehrlann
Copy link
Collaborator

Kehrlann commented Oct 15, 2024

Issue

When running on Firefox, conditional mediation often fails out of the box. Then the JS code redirects me to /login?error, where conditional mediation happens again immediately. This makes Firefox crash.

Sometimes conditional mediation does not throw and error, and the issues only start occurring when the user clicks the "sign in with passkeys" button.

Both Safari and Chrome have slightly different behaviors, with no visible redirect loop, but there are blocking bugs that tend to crash the running tab.

Environment

Running on http://localhost:8080 (no TLS)
No password-manager extension
Firefox developer edition, 132.0b6
MacOS Sonoma 14.6.1

Ideas

  • We could avoid triggering conditional mediation when we are in ?error mode
  • There might be a need to turn conditional mediation on or off from the API
  • For now we'll remove conditional mediation alltogether
Kehrlann added a commit that referenced this issue Oct 15, 2024
- Conditional mediation causes infinte redirect loop and crashes, see
  #73
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant