Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Commit

Permalink
javascript: disable conditional mediation
Browse files Browse the repository at this point in the history
- Conditional mediation causes infinte redirect loop and crashes, see
  #73
  • Loading branch information
Kehrlann committed Oct 15, 2024
1 parent 5518353 commit 6069d1c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion spring-security-javascript/lib/webauthn-login.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,7 @@ export async function setupLogin(headers, contextPath, signinButton) {
await authenticateOrError(headers, contextPath, false);
});

await conditionalMediation(headers, contextPath);
// FIXME: conditional mediation triggers browser crashes
// See: https://github.com/rwinch/spring-security-webauthn/issues/73
// await conditionalMediation(headers, contextPath);
}
4 changes: 3 additions & 1 deletion spring-security-javascript/test/webauthn-login.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ describe("webauthn-login", () => {
assert.calledOnceWithMatch(signinButton.addEventListener, "click", match.typeOf("function"));
});

it("uses conditional mediation when available", async () => {
// FIXME: conditional mediation triggers browser crashes
// See: https://github.com/rwinch/spring-security-webauthn/issues/73
xit("uses conditional mediation when available", async () => {
isConditionalMediationAvailableStub.resolves(true);

const headers = { "x-header": "value" };
Expand Down

0 comments on commit 6069d1c

Please sign in to comment.