Implement auto-login feature #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is a good way to do it but if anyone has better idea please comment! |
rwieruch
reviewed
Dec 18, 2017
src/components/Dashboard/index.js
Outdated
| @@ -35,7 +35,7 @@ class Dashboard extends React.Component { | |||
| } | |||
|
|
|||
| const mapStateToProps = state => ({ | |||
| isAuthed: Boolean(state.session.session), | |||
| isAuthed: Boolean(state.session.user), | |||
There was a problem hiding this comment.
FYI: Just another way to make a truthy or falsy here is using !!state.session.user . But that one is alright too! As I see, it already was there before :)
There was a problem hiding this comment.
I like the !!something way, much cleaner.
There was a problem hiding this comment.
I may use it too often in my own projects and I heard people complaining about it, but I find it the easiest way to transform any JavaScript literal into a boolean.
|
LGTM without having tested it. But concise and nice implementation! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the current token is valid every time user refreshes the page. If it is, fetch user information and log the user in. If it is not, log the user out and then open the login window.