Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layout #239

Closed
wants to merge 21 commits into from
Closed

New layout #239

wants to merge 21 commits into from

Conversation

johnivanoff
Copy link

99% new css. flexbox and more responsive. Only a few content changes. Thoughts? comments? Needs some IE tweaks. can correct if you want to move forward with his.

@mpapis
Copy link
Member

mpapis commented Oct 11, 2014

can you rebase on master?

@mpapis
Copy link
Member

mpapis commented Oct 11, 2014

it's quite nice, eager to merge ... with some hints:

  1. rebase on master so it can be merged
  2. make sponsors smaller, you can merge them all into one box
  3. it's to early for RVM2 - could you restore the rvm1 logo for now
  4. you can drop the comic from index, it looks really bad on my screen (1920x1080)
  5. shorten the section width, I have tested with few different resolutions and usually I get 2 or 3 columns with big gap on right
  6. sections look strange, the first few have similar height, but overall they look worse then a camel, some are just 1-3 lines and one is 22 ... tried reorganizing with: https://gist.github.com/mpapis/3431490a555961b215de
  7. In current version the menu goes to right side on bigger screens, with your changes this is gone, on purpose or you did not notice it earlier?

lets see how it looks after changes ;)

@mpapis mpapis mentioned this pull request Oct 11, 2014
@mpapis
Copy link
Member

mpapis commented Oct 11, 2014

closing in favor of #240 - send you invitation to rvm team so we can work on it together

@mpapis mpapis closed this Oct 11, 2014
@mpapis mpapis removed the need info label Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants