Merge pull request frappe#45040 from ruthra-kumar/use_idx_for_identif…

…ying refactor: use `idx` for identifying row
ruthra-kumar · Jan 2, 2025 · e609a6a · e609a6a
2 parents 1f26fec + 51354c8
commit e609a6a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/erpnext/controllers/tests/test_reactivity.py b/erpnext/controllers/tests/test_reactivity.py
@@ -56,7 +56,7 @@ def test_01_basic_item_details(self):
 		)
 		itm = si.append("items")
 		itm.item_code = self.item
-		si.process_item_selection(si.items[0].name)
+		si.process_item_selection(itm.idx)
 		self.assertEqual(itm.rate, 90)
 
 		df = qb.DocType("DocField")

diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js
@@ -505,7 +505,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
 				doc: doc,
 				method: "process_item_selection",
 				args: {
-					item: item.name
+					item_idx: item.idx
 				},
 				callback: function(r) {
 					if(!r.exc) {

diff --git a/erpnext/utilities/transaction_base.py b/erpnext/utilities/transaction_base.py
@@ -288,9 +288,9 @@ def fetch_item_details(self, item: dict) -> dict:
 		)
 
 	@frappe.whitelist()
-	def process_item_selection(self, item):
+	def process_item_selection(self, item_idx):
 		# Server side 'item' doc. Update this to reflect in UI
-		item_obj = self.get("items", {"name": item})[0]
+		item_obj = self.get("items", {"idx": item_idx})[0]
 
 		# 'item_details' has latest item related values
 		item_details = self.fetch_item_details(item_obj)