fix: Correct reorg issue in the ln helper function #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/patch-reorg
branch
from
357d299 to
d4bdf18
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
Previously, an unexpected behavior in the ln helper function had gone unnoticed. However, while Rusty Russell was working on [1], he discovered a bug in lnprototest. Specifically, within the helper function that opens a channel, there was an incorrect way of counting the current block height. Ideally, this logic should be abstracted elsewhere. This commit addresses the block height counting error and resolves the bug identified in [1]. [1] ElementsProject/lightning#6628 Link: https://discord.com/channels/899980449231814676/941465665540325397/1154259454716563537 Reported-by: Rusty Russell <[email protected]> Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/patch-reorg
branch
3 times, most recently
from
ecaf636 to
47aca52
Compare
Currently cln is moving to a runtime like feature, so this enable to add --developer at the lightnind invoication. This break a lot of scripts but looks more cool :) Introduced in cln at commit ElementsProject/lightning@64ab7c0 Unknown option '--enable-developer' Usage: ./configure [--reconfigure] [setting=value] [options] If --reconfigure is specified, config.vars will set defaults. Default settings: CSANFLAGS = CC (default cc) CWARNFLAGS (default -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -Werror -Wno-maybe-uninitialized -Wshadow=local) COPTFLAGS (default -Og) CDEBUGFLAGS (default -std=gnu11 -g -fstack-protector-strong) CONFIGURATOR_CC (default cc) To override compile line for configurator itself PYTEST (default python3 -m pytest) VALGRIND (default 0) Options include: --prefix= (default /usr/local) Prefix for make install --enable/disable-debugbuild (default disable) Extra debug checks in the build, good for testing --enable/disable-compat (default enable) Compatibility mode, good to disable to see if your software breaks --enable/disable-valgrind (default (autodetect)) Run tests with Valgrind --enable/disable-static (default disable) Static link sqlite3 and zlib libraries --enable/disable-coverage (default disable) Compile with Clang coverage instrumentation --enable/disable-address-sanitizer (default disable) Compile with address-sanitizer --enable/disable-ub-sanitizer (default disable) Compile with undefined behaviour sanitizer --enable/disable-fuzzing (default disable) Compile with fuzzing --enable/disable-rust (default enable) Compile with Rust support Reported-by: Github Action Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/patch-reorg
branch
from
47aca52 to
69ecdf5
Compare
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 21, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 22, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
rustyrussell
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Sep 25, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
cdecker
pushed a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Sep 26, 2023
This commit is upgrading lnprototest to patch some bugs reported by Rusty. Including: - Support the Drop of the --developer flag at runtime (rustyrussell/lnprototest#106) - Fixing reorg issue in the ln helper function (rustyrussell/lnprototest#107) Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an unexpected behavior in the ln helper function had gone
unnoticed. However, while Rusty Russell was working on [1], he
discovered a bug in lnprototest.
Specifically, within the helper function that opens a channel, there
was an incorrect way of counting the current block height. Ideally,
this logic should be abstracted elsewhere.
This commit addresses the block height counting
error and resolves the bug identified in [1].
[1] ElementsProject/lightning#6628
Link: https://discord.com/channels/899980449231814676/941465665540325397/1154259454716563537
Reported-by: Rusty Russell [email protected]
Signed-off-by: Vincenzo Palazzo [email protected]