Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ins trait #14

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Replace ins trait #14

merged 7 commits into from
Feb 11, 2024

Conversation

lukhio
Copy link
Collaborator

@lukhio lukhio commented Feb 11, 2024

We have a finite set on instructions format so there is no need for a trait. An enum works.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 215 lines in your changes are missing coverage. Please review.

Comparison is base (97e1601) 90.57% compared to head (4abce6e) 80.24%.

Files Patch % Lines
src/disasm.rs 0.00% 189 Missing ⚠️
src/dex_classes.rs 0.00% 14 Missing ⚠️
src/code_item.rs 0.00% 11 Missing ⚠️
src/dex_file.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   90.57%   80.24%   -10.34%     
===========================================
  Files          22       22               
  Lines        6199     5410      -789     
===========================================
- Hits         5615     4341     -1274     
- Misses        584     1069      +485     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukhio lukhio merged commit d627798 into main Feb 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant