Update RTCRtpCodec
#3742
Closed
Update RTCRtpCodec
#3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Dec 13, 2023
crates/web-sys/webidls/unstable/RTCRtpEncodingParameters.webidl
Outdated
Show resolved
Hide resolved
Comment on lines
55
to
56
| required DOMString mimeType; | ||
| required unsigned long clockRate; |
There was a problem hiding this comment.
Suggested change
| required DOMString mimeType; | |
| required unsigned long clockRate; | |
| DOMString mimeType; | |
| unsigned long clockRate; |
I believe both of these can't be required, because it changes the new() function of RTCRtpCodecParameters, which is a breaking change.
daxpedda
requested changes
Dec 13, 2023
Comment on lines
55
to
56
| DOMString mimeType; | ||
| unsigned long clockRate; |
There was a problem hiding this comment.
Apologies, I think these two have to be required after all.
You should take a look yourself and see what causes a breaking change in the API or not.
There was a problem hiding this comment.
Could you add a newline at the end of this file and the other as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
RTCRtpCodecaccordingly to spec.Also added unstable fields for
RTCRtpEncodingParameters.