Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to wasm-bindgen-futures #3594

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Minor improvements to wasm-bindgen-futures #3594

merged 1 commit into from
Sep 6, 2023

Conversation

Pauan
Copy link
Contributor

@Pauan Pauan commented Sep 5, 2023

  • Constructs a single vtable instead of recreating it repeatedly.
  • Adds in proper implementation for Waker::wake.

daxpedda
daxpedda approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@daxpedda daxpedda merged commit f89a0fb into rustwasm:main Sep 6, 2023
25 checks passed
@Pauan Pauan deleted the improve-futures branch September 6, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pauan @daxpedda