bugfix: DWARF transformation failure in some code #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this against the previous bug in rustwasm/wasm-bindgen#3483 and can confirm this resolves the issue. |
|
Thanks a ton for this PR @nokotan 🙏 |
|
Agreed! Thanks a ton, @nokotan !!! This is going to have a huge impact if we can use this now: https://marketplace.visualstudio.com/items?itemName=ms-vscode.wasm-dwarf-debugging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #247
In the original PR (#231), once the debug program sequence begins, it tries to convert any address in original wasm binaries, even if the address is not mapped in transformed wasm binaries.
That is based on the assumption that any consequence address is existent in transformed binary, if sequence-beginning address can be mapped to transformed one. However, the assumption seems not to be correct especially in inline functions.
In this PR, all addresses that convert function cannot converted are just ignored in DWARF line program converting process.