Probe terminal size for every line #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove initializer - Probe for size every line - Ignore invalid input during reset - In case probe fails, assume 24 * 80 size
- Removed separate enums for each number of steps - Use single array with position - Implement IntoIterator on Output instead of Iterator
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noline initializes the terminal once, probing the size of the terminal. In #35 a new feature was proposed to be able to re-initialize the terminal. The initializer is a bit strict, and will cause an error if the input from the terminal is not exactly as expected, as seen in #12.
This PR solves both these problems by: