Start porting <c3d/maths.h>, vectors and matrices #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not much but it should be extensible enough to apply for other uniform types. We might want a generic impl for &[u8] or something as well to support custom uniform types, but that gets trickier.
7 tasks
Also add some doc aliases for citro3d functions. We could probably stand to add more aliases to other wrappers too.
Finally, something that I don't think totally sucks. Pick some sane defaults for some fields, and use generics to split between orthographic and perspective implementations. It's still not perfect but I think this looks a lot more ergonomic to use vs what I had before (and compared to the C APIs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose safe wrappers for
Mtx_APIs, for now mainly just the constructors that are used for projection matrices, since those will probably be the most commonly used. This PR also adds aUniformtrait which is how those matrices are bound to a shader to get sent to the GPU, and should also work for other types likeFVecand possibly even custom data types.I think once I get this to pass CI I will merge it since I've iterated a few times already and it's starting to get a little bigger than I should have let it, really... We're getting closer to a fully safe
triangleexample though!TODOs remaining:
vector math, transformations etc. Mightwill save for another PRupdate_blahper matrix / vector type / dimension. Maybe a trait would be nice?