Fix compilation error #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that there are other places where usage of raw pointers could be replaced by |
|
@jhwgh1968 If you have any time in between, could you give it a review as well, please? Thank you! 🫂 |
…`. Both types have the same ABI, but the first one is safer to deal with.
jhwgh1968
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
This was written for an older version of Rust based on a project I wrote at the time. In order to compile it, I had to put it "back into the project" it came from.
I have not had to do anything that low level since then, so I don't know if it will work. But at least there is nothing obviously wrong with it.
simonsan
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use expressions instead of statements when returning the value to the outer scope, and use
Option<NonNull<T>>instead of raw pointers because it is safer and still ABI-compatible.