Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread rng #1547

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Thread rng #1547

merged 2 commits into from
Jan 9, 2025

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Jan 3, 2025

  • Added a CHANGELOG.md entry

Summary

Add the thread_rng feature flag

Motivation

dhardy added 2 commits January 3, 2025 10:58
(Skip beta.2 to match rand_distr, which also gets bumped.)
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only concern is the features circularity (std -> thread_rng -> std). I never used them in practice, so I don't know whether they may cause issues or not.

@dhardy
Copy link
Member Author

dhardy commented Jan 9, 2025

My only concern is the features circularity (std -> thread_rng -> std).

But std doesn't require thread_rng? default does.

@newpavlov
Copy link
Member

Ah, true. I wasn't looking careful enough.

@dhardy dhardy merged commit 16eb7de into rust-random:master Jan 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants