wasm_js: remove the separate codepath for Node.js and TLS caching #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
changed the title
|
Ah, I thought you are going to merge #541 first. |
|
I thought that when you wrote "Sure, I'm a fan of splitting things up." you meant that we should continue with this PR. :) |
newpavlov
changed the title
daxpedda
suggested changes
Dec 4, 2024
There was a problem hiding this comment.
There are also some Node.js related leftovers on the Error type.
I thought that when you wrote "Sure, I'm a fan of splitting things up." you meant that we should continue with this PR. :)
Apologies, I probably didn't read carefully enough. I understood it just as a follow-up, not a replacement.
Co-authored-by: daxpedda <[email protected]>
daxpedda
approved these changes
Dec 4, 2024
daxpedda
reviewed
Dec 4, 2024
Co-authored-by: daxpedda <[email protected]>
|
We entirely forgot the whole |
newpavlov
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acquire of "global" objects is relatively cheap (adds ~40 ns of overhead), so it make sense to do it on each call instead of trying to cache objects in a TLS variable.
Additionally, removes the separate codepath for Node.js since it fully supports the Web Crypto API since v19 (released 2022-10-18).