Run Wasm tests in workers as well #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
wasm-test-workers
branch
2 times, most recently
from
7ce3c73 to
94f3621
Compare
|
Apparently the Node.js was broken already. I unfortunately don't know enough about Node.js, locally it seems to work for me, so I'm going to do some tests with the CI. |
daxpedda
force-pushed
the
wasm-test-workers
branch
3 times, most recently
from
fce0241 to
f03425f
Compare
daxpedda
commented
Nov 29, 2024
| @@ -240,31 +240,48 @@ jobs: | |||
|
|
|||
| web: | |||
| name: Web | |||
| runs-on: ubuntu-22.04 | |||
| runs-on: ubuntu-24.04 | |||
There was a problem hiding this comment.
This was required because the old Node.js version is incompatible with the latest Rust versions, which enabled reference types by default. See the blog post about it.
Alternatively I can also use the official GH action to install a newer version, let me know if you want me to do something here.
daxpedda
force-pushed
the
wasm-test-workers
branch
from
f03425f to
245065a
Compare
newpavlov
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change runs Wasm tests in workers as well.
Fixes #319.