CI/CD: BLAS MSRV and Clippy

.github/workflows/ci.yaml

@@ -88,6 +88,20 @@ jobs:
         run: sudo apt-get install libopenblas-dev gfortran
       - run: ./scripts/all-tests.sh "$FEATURES" ${{ matrix.rust }}
 
+  blas-msrv:
+    runs-on: ubuntu-latest
+    name: blas-msrv
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: 1.67.0  # BLAS MSRV
+      - uses: rui314/setup-mold@v1
+      - uses: Swatinem/rust-cache@v2
+      - name: Install openblas
+        run: sudo apt-get install libopenblas-dev gfortran
+      - run: ./scripts/blas-integ-tests.sh "$FEATURES" 1.67.0
+
   miri:
     runs-on: ubuntu-latest
     name: miri

README.rst

@@ -156,6 +156,14 @@ there is no tight coupling to the ``blas-src`` version, so version selection is
 0.13        0.2.0        0.6.0
 =========== ============ ================ ==============
 
+------------
+BLAS on MSRV
+------------
+
+Although ``ndarray`` currently maintains an MSRV of 1.64.0, this is separate from the MSRV (either stated or real) of the various BLAS providers.
+As of the time of writing, ``openblas`` currently supports MSRV of 1.67.0.
+So, while ``ndarray`` and ``openblas-src`` are compatible, they can only work together with toolchains 1.67.0 or above.
+
 Recent Changes
 --------------
 

crates/ndarray-gen/src/lib.rs

@@ -8,5 +8,4 @@
 // except according to those terms.
 
 /// Build ndarray arrays for test purposes
-
 pub mod array_builder;

examples/bounds_check_elim.rs

@@ -57,7 +57,7 @@ pub fn test1d_single_mut(a: &mut Array1<f64>, i: usize) -> f64
 #[no_mangle]
 pub fn test1d_len_of(a: &Array1<f64>) -> f64
 {
-    let a = &*a;
+    let a = a;
     let mut sum = 0.;
     for i in 0..a.len_of(Axis(0)) {
         sum += a[i];

ndarray-rand/tests/tests.rs

@@ -122,7 +122,7 @@ fn sampling_works(a: &Array2<f64>, strategy: SamplingStrategy, axis: Axis, n_sam
     let samples = a.sample_axis(axis, n_samples, strategy);
     samples
         .axis_iter(axis)
-        .all(|lane| is_subset(&a, &lane, axis))
+        .all(|lane| is_subset(a, &lane, axis))
 }
 
 // Check if, when sliced along `axis`, there is at least one lane in `a` equal to `b`

scripts/all-tests.sh

@@ -23,8 +23,9 @@ cargo test -v -p ndarray -p ndarray-rand --release --features "$FEATURES" $QC_FE
 # BLAS tests
 cargo test -p ndarray --lib -v --features blas
 cargo test -p blas-mock-tests -v
-cargo test -p blas-tests -v --features blas-tests/openblas-system
-cargo test -p numeric-tests -v --features numeric-tests/test_blas
+if [ "$CHANNEL" != "1.64.0" ]; then
+    ./scripts/blas-integ-tests.sh "$FEATURES" $CHANNEL
+fi
 
 # Examples
 cargo test --examples

scripts/blas-integ-tests.sh

@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -x
+set -e
+
+FEATURES=$1
+CHANNEL=$2
+
+# BLAS tests
+cargo test -p blas-tests -v --features blas-tests/openblas-system
+cargo test -p numeric-tests -v --features numeric-tests/test_blas

src/argument_traits.rs

@@ -11,7 +11,7 @@ pub trait AssignElem<T>
 }
 
 /// Assignable element, simply `*self = input`.
-impl<'a, T> AssignElem<T> for &'a mut T
+impl<T> AssignElem<T> for &mut T
 {
     fn assign_elem(self, input: T)
     {
@@ -20,7 +20,7 @@ impl<'a, T> AssignElem<T> for &'a mut T
 }
 
 /// Assignable element, simply `self.set(input)`.
-impl<'a, T> AssignElem<T> for &'a Cell<T>
+impl<T> AssignElem<T> for &Cell<T>
 {
     fn assign_elem(self, input: T)
     {
@@ -29,7 +29,7 @@ impl<'a, T> AssignElem<T> for &'a Cell<T>
 }
 
 /// Assignable element, simply `self.set(input)`.
-impl<'a, T> AssignElem<T> for &'a MathCell<T>
+impl<T> AssignElem<T> for &MathCell<T>
 {
     fn assign_elem(self, input: T)
     {
@@ -39,7 +39,7 @@ impl<'a, T> AssignElem<T> for &'a MathCell<T>
 
 /// Assignable element, the item in the MaybeUninit is overwritten (prior value, if any, is not
 /// read or dropped).
-impl<'a, T> AssignElem<T> for &'a mut MaybeUninit<T>
+impl<T> AssignElem<T> for &mut MaybeUninit<T>
 {
     fn assign_elem(self, input: T)
     {

src/array_serde.rs

@@ -98,7 +98,7 @@ where
 // private iterator wrapper
 struct Sequence<'a, A, D>(Iter<'a, A, D>);
 
-impl<'a, A, D> Serialize for Sequence<'a, A, D>
+impl<A, D> Serialize for Sequence<'_, A, D>
 where
     A: Serialize,
     D: Dimension + Serialize,
@@ -162,7 +162,7 @@ impl<'de> Deserialize<'de> for ArrayField
     {
         struct ArrayFieldVisitor;
 
-        impl<'de> Visitor<'de> for ArrayFieldVisitor
+        impl Visitor<'_> for ArrayFieldVisitor
         {
             type Value = ArrayField;
 

src/arraytraits.rs

@@ -128,7 +128,7 @@ where
 /// Return `true` if the array shapes and all elements of `self` and
 /// `rhs` are equal. Return `false` otherwise.
 #[allow(clippy::unconditional_recursion)] // false positive
-impl<'a, A, B, S, S2, D> PartialEq<&'a ArrayBase<S2, D>> for ArrayBase<S, D>
+impl<A, B, S, S2, D> PartialEq<&ArrayBase<S2, D>> for ArrayBase<S, D>
 where
     A: PartialEq<B>,
     S: Data<Elem = A>,
@@ -144,7 +144,7 @@ where
 /// Return `true` if the array shapes and all elements of `self` and
 /// `rhs` are equal. Return `false` otherwise.
 #[allow(clippy::unconditional_recursion)] // false positive
-impl<'a, A, B, S, S2, D> PartialEq<ArrayBase<S2, D>> for &'a ArrayBase<S, D>
+impl<A, B, S, S2, D> PartialEq<ArrayBase<S2, D>> for &ArrayBase<S, D>
 where
     A: PartialEq<B>,
     S: Data<Elem = A>,

src/data_traits.rs

@@ -407,7 +407,7 @@ where A: Clone
     }
 }
 
-unsafe impl<'a, A> RawData for ViewRepr<&'a A>
+unsafe impl<A> RawData for ViewRepr<&A>
 {
     type Elem = A;
 
@@ -420,7 +420,7 @@ unsafe impl<'a, A> RawData for ViewRepr<&'a A>
     private_impl! {}
 }
 
-unsafe impl<'a, A> Data for ViewRepr<&'a A>
+unsafe impl<A> Data for ViewRepr<&A>
 {
     fn into_owned<D>(self_: ArrayBase<Self, D>) -> Array<Self::Elem, D>
     where
@@ -437,15 +437,15 @@ unsafe impl<'a, A> Data for ViewRepr<&'a A>
     }
 }
 
-unsafe impl<'a, A> RawDataClone for ViewRepr<&'a A>
+unsafe impl<A> RawDataClone for ViewRepr<&A>
 {
     unsafe fn clone_with_ptr(&self, ptr: NonNull<Self::Elem>) -> (Self, NonNull<Self::Elem>)
     {
         (*self, ptr)
     }
 }
 
-unsafe impl<'a, A> RawData for ViewRepr<&'a mut A>
+unsafe impl<A> RawData for ViewRepr<&mut A>
 {
     type Elem = A;
 
@@ -458,7 +458,7 @@ unsafe impl<'a, A> RawData for ViewRepr<&'a mut A>
     private_impl! {}
 }
 
-unsafe impl<'a, A> RawDataMut for ViewRepr<&'a mut A>
+unsafe impl<A> RawDataMut for ViewRepr<&mut A>
 {
     #[inline]
     fn try_ensure_unique<D>(_: &mut ArrayBase<Self, D>)
@@ -475,7 +475,7 @@ unsafe impl<'a, A> RawDataMut for ViewRepr<&'a mut A>
     }
 }
 
-unsafe impl<'a, A> Data for ViewRepr<&'a mut A>
+unsafe impl<A> Data for ViewRepr<&mut A>
 {
     fn into_owned<D>(self_: ArrayBase<Self, D>) -> Array<Self::Elem, D>
     where
@@ -492,7 +492,7 @@ unsafe impl<'a, A> Data for ViewRepr<&'a mut A>
     }
 }
 
-unsafe impl<'a, A> DataMut for ViewRepr<&'a mut A> {}
+unsafe impl<A> DataMut for ViewRepr<&mut A> {}
 
 /// Array representation trait.
 ///
@@ -533,7 +533,7 @@ pub unsafe trait DataOwned: Data
 pub unsafe trait DataShared: Clone + Data + RawDataClone {}
 
 unsafe impl<A> DataShared for OwnedArcRepr<A> {}
-unsafe impl<'a, A> DataShared for ViewRepr<&'a A> {}
+unsafe impl<A> DataShared for ViewRepr<&A> {}
 
 unsafe impl<A> DataOwned for OwnedRepr<A>
 {
@@ -571,7 +571,7 @@ unsafe impl<A> DataOwned for OwnedArcRepr<A>
     }
 }
 
-unsafe impl<'a, A> RawData for CowRepr<'a, A>
+unsafe impl<A> RawData for CowRepr<'_, A>
 {
     type Elem = A;
 
@@ -587,7 +587,7 @@ unsafe impl<'a, A> RawData for CowRepr<'a, A>
     private_impl! {}
 }
 
-unsafe impl<'a, A> RawDataMut for CowRepr<'a, A>
+unsafe impl<A> RawDataMut for CowRepr<'_, A>
 where A: Clone
 {
     #[inline]
@@ -615,7 +615,7 @@ where A: Clone
     }
 }
 
-unsafe impl<'a, A> RawDataClone for CowRepr<'a, A>
+unsafe impl<A> RawDataClone for CowRepr<'_, A>
 where A: Clone
 {
     unsafe fn clone_with_ptr(&self, ptr: NonNull<Self::Elem>) -> (Self, NonNull<Self::Elem>)
@@ -681,7 +681,7 @@ unsafe impl<'a, A> Data for CowRepr<'a, A>
     }
 }
 
-unsafe impl<'a, A> DataMut for CowRepr<'a, A> where A: Clone {}
+unsafe impl<A> DataMut for CowRepr<'_, A> where A: Clone {}
 
 unsafe impl<'a, A> DataOwned for CowRepr<'a, A>
 {

src/dimension/axes.rs

@@ -60,7 +60,7 @@ pub struct AxisDescription
 copy_and_clone!(AxisDescription);
 copy_and_clone!(['a, D] Axes<'a, D>);
 
-impl<'a, D> Iterator for Axes<'a, D>
+impl<D> Iterator for Axes<'_, D>
 where D: Dimension
 {
     /// Description of the axis, its length and its stride.
@@ -99,7 +99,7 @@ where D: Dimension
     }
 }
 
-impl<'a, D> DoubleEndedIterator for Axes<'a, D>
+impl<D> DoubleEndedIterator for Axes<'_, D>
 where D: Dimension
 {
     fn next_back(&mut self) -> Option<Self::Item>

src/dimension/ndindex.rs

@@ -255,7 +255,7 @@ unsafe impl<const N: usize> NdIndex<IxDyn> for [Ix; N]
     }
 }
 
-impl<'a> IntoDimension for &'a [Ix]
+impl IntoDimension for &[Ix]
 {
     type Dim = IxDyn;
     fn into_dimension(self) -> Self::Dim
@@ -264,7 +264,7 @@ impl<'a> IntoDimension for &'a [Ix]
     }
 }
 
-unsafe impl<'a> NdIndex<IxDyn> for &'a IxDyn
+unsafe impl NdIndex<IxDyn> for &IxDyn
 {
     fn index_checked(&self, dim: &IxDyn, strides: &IxDyn) -> Option<isize>
     {
@@ -276,7 +276,7 @@ unsafe impl<'a> NdIndex<IxDyn> for &'a IxDyn
     }
 }
 
-unsafe impl<'a> NdIndex<IxDyn> for &'a [Ix]
+unsafe impl NdIndex<IxDyn> for &[Ix]
 {
     fn index_checked(&self, dim: &IxDyn, strides: &IxDyn) -> Option<isize>
     {

src/impl_cow.rs

@@ -11,7 +11,7 @@ use crate::imp_prelude::*;
 /// Methods specific to `CowArray`.
 ///
 /// ***See also all methods for [`ArrayBase`]***
-impl<'a, A, D> CowArray<'a, A, D>
+impl<A, D> CowArray<'_, A, D>
 where D: Dimension
 {
     /// Returns `true` iff the array is the view (borrowed) variant.

src/impl_views/constructors.rs

@@ -230,7 +230,7 @@ where D: Dimension
 }
 
 /// Private array view methods
-impl<'a, A, D> ArrayView<'a, A, D>
+impl<A, D> ArrayView<'_, A, D>
 where D: Dimension
 {
     /// Create a new `ArrayView`
@@ -254,7 +254,7 @@ where D: Dimension
     }
 }
 
-impl<'a, A, D> ArrayViewMut<'a, A, D>
+impl<A, D> ArrayViewMut<'_, A, D>
 where D: Dimension
 {
     /// Create a new `ArrayView`

src/impl_views/indexing.rs

@@ -100,7 +100,7 @@ pub trait IndexLonger<I>
     unsafe fn uget(self, index: I) -> Self::Output;
 }
 
-impl<'a, 'b, I, A, D> IndexLonger<I> for &'b ArrayView<'a, A, D>
+impl<'a, I, A, D> IndexLonger<I> for &ArrayView<'a, A, D>
 where
     I: NdIndex<D>,
     D: Dimension,

src/impl_views/splitting.rs

@@ -11,7 +11,7 @@ use crate::slice::MultiSliceArg;
 use num_complex::Complex;
 
 /// Methods for read-only array views.
-impl<'a, A, D> ArrayView<'a, A, D>
+impl<A, D> ArrayView<'_, A, D>
 where D: Dimension
 {
     /// Split the array view along `axis` and return one view strictly before the