Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Linspace and Logspace iterators #1348

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

johann-cm
Copy link
Contributor

This is a simple PR to make the Linspace and Logspace iterators, as well as the functions linspace, range, and logspace publicly available.
Resolves #1065.

@nilgoyette
Copy link
Collaborator

One could say that it's strange for ndarray to provide a lin/log-space iterator. Imo, this code already exist and we're already maintaining it. We might as well share it to make it useful to more people. 👍

I don't mind merging this. I'll wait one day to let the other maintainers express their opinion, if they want.

Copy link

@lquenti lquenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilgoyette
Copy link
Collaborator

Thank you for your contribution @johann-cm

@nilgoyette nilgoyette merged commit 8d91bc2 into rust-ndarray:master Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export linspace module
3 participants