Improve retries in the installation scripts #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
force-pushed
the
feat/improve-retries
branch
3 times, most recently
from
9213043 to
605e484
Compare
Veetaha
force-pushed
the
feat/improve-retries
branch
from
605e484 to
554d008
Compare
xFrednet
approved these changes
Nov 8, 2023
|
Everything looks good to me, thank you for the update :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today on our CI the installation of marker randomly failed:
GitHub returned 403 due to some internal bugs I suppose. To fix this I added
--retry-all-errorswhich should retry in such cases and added more configurations for retries. This way on CI we use the retry config that gives up in 30 minutes. This solves the problem of red master CI when doing a release (part of #274).