Reduce build time by ~70% #37
Conversation
|
Locally testing this against master, it seems like it introduces some differences in the output -- it's hard to say whether those are benign or not, but my guess is that the current more primitive approach is likely (more) correct. So without at least an explanation and justification for those differences I'm inclined to close this. |
|
It's been a little bit since I've touched this. What are the differences, exactly? |
|
Well, I just diff'd the output directory, I didn't investigate too thoroughly. The differences I saw amounted to different counts for various people, but without much more work tracking those to differences in accounting (e.g. commits attributed) isn't something I can do. |
|
Hm. After rebasing (I presume you did this), the only differences are in Rust 1.34. No other version is affected from what I can see. The people and contributions jumps from 277 and 3930 respectively to 286 and 5503. So something in the Rust repository is making this change think there's an extra ~1600 contributions. If you happen to know what change may have occurred around that time, that would help me pinpoint what needs to change. |
With this minor patch, we keep track of the most recent version and only calculate contributions from that point forward. This, in turn, means we're no longer recalculating contributions for the first commit for every release.
This only affects the main repository, not any submodules, but it's still significant enough to cut build time (in release mode) from 98 seconds to 28 seconds on my machine.