Ensure package hash is stable #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fastly added metadata collection[^1] to the CLI in version 10.6.0. The metadata includes the heap size during the build, which is not stable over time. Because of that, Terraform always detected a change to the compute package, even though no code had changed. Disabling the metadata collection ensures that the package hash is stable between builds, thus reducing the noise in Terraform. [^1]: https://developer.fastly.com/learning/tools/cli/#metadata-collection
|
I've reported this as an issue here: fastly/cli#1125. |
Mark-Simulacrum
approved these changes
Feb 6, 2024
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Feb 15, 2024
The collection of metadata was disabled in rust-lang#387, because the metadata contained an unstable property that broke the change detection in Terraform. This issue has been resolved upstream by introducing buckets for the heap allocation size, which reduces the risk of changes in the metadata while preserving the usefulness of the property. See fastly/cli#1130 for details on the buckets.
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Apr 16, 2024
The collection of metadata was disabled in rust-lang#387, because the metadata contained an unstable property that broke the change detection in Terraform. This issue has been resolved upstream by introducing buckets for the heap allocation size, which reduces the risk of changes in the metadata while preserving the usefulness of the property. See fastly/cli#1130 for details on the buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastly added metadata collection1 to the CLI in version 10.6.0. The metadata includes the heap size during the build, which is not stable over time. Because of that, Terraform always detected a change to the compute package, even though no code had changed.
Disabling the metadata collection ensures that the package hash is stable between builds, thus reducing the noise in Terraform.
Footnotes
https://developer.fastly.com/learning/tools/cli/#metadata-collection ↩