-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more mailmap entries #132474
base: master
Are you sure you want to change the base?
Add more mailmap entries #132474
Conversation
This adds a bunch of missing mailmap entries for many people. These are needed when using rust-lang/team information in rust-lang/thanks, as the emails there may differ. These are all the "easy" ones, where there was a mailmap entry already, making it clear which one is the preferred email address.
The people updated in this commit have contributed under different email addresses than the ones they have used in rust-lang/team. A new change will use team data for thanks reviewers, which requires this to be in sync. Therefore, I have updated many of the people that I've noticed being duplicated after the change.
rustbot has assigned @Mark-Simulacrum. Use |
84bc564
to
a04081b
Compare
Added a few additional ones: @b-naber @Centri3 @nikomatsakis @nikic |
5a65d9d
to
18b47b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed Jieyou Xu also shows up at least twice on thanks/all. Once as Jieyou Xu <********@**********>
and once as 许杰友 Jieyou Xu (Joe) <********@**********>
(I've redacted the email addresses but they are the same). There's already a mailmap entry for them but it should be extended.
my additional entry fixes this |
Jake Goulding <[email protected]> <[email protected]> | ||
Jake Goulding <[email protected]> <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jake Goulding <jake.goulding@gmail.com> <jake.goulding@integer32.com> | |
Jake Goulding <jake.goulding@gmail.com> <[email protected]> | |
Jake Goulding <jake.goulding@integer32.com> <jake.goulding@gmail.com> | |
Jake Goulding <jake.goulding@integer32.com> <[email protected]> |
This is an attempt to make my Integer32 email the canonical one; I think I got the syntax right...
r=me whenever |
If you have been pinged: I'm adding a mailmap entry for you to keep thanks.rust-lang.org working properly.
I have picked the canonical address mostly arbitrarily. If you want a different one as the canonical address, please tell me here.
more details on the change
builds on top of #132471, this containing the less obvious changes that add new canonical email addresses instead of just adding new current ones.
The people updated in this commit have contributed under different email
addresses than the ones they have used in rust-lang/team.
rust-lang/thanks#53 will use team data for thanks reviewers, which requires this to be in
sync.
Therefore, I have updated many of the people that I've noticed being
duplicated after the change.
I'm adding a novel entry for you: @apiraino @KodrAus @cramertj @sunfishcode @Eh2406 @skade @huonw @jsha @shepmaster @workingjubilee @rbtcollins @nrc @fitzgen @sophiajt @tmiasko @notriddle @TimNN @WaffleLapkin