Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: refactor test helpers within ide-completions #18887

Merged

Conversation

vishruth-thimmaiah
Copy link
Contributor

This PR moves common helper functions within the test files of the ide-completions crate to tests.rs.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2025
@vishruth-thimmaiah vishruth-thimmaiah force-pushed the refactor_completions_tests branch from 0b968d7 to b21a5f8 Compare January 8, 2025 18:21
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril added this pull request to the merge queue Jan 9, 2025
Merged via the queue into rust-lang:master with commit d3a49d3 Jan 9, 2025
9 checks passed
@lnicola lnicola changed the title refactor test helpers within ide-completions internal: refactor test helpers within ide-completions Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants