Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable neon for apple targets #231

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Disable neon for apple targets #231

merged 1 commit into from
Dec 6, 2024

Conversation

Jake-Shadle
Copy link
Contributor

Workaround for #230.

Don't really have time to look at this more in depth, so this just disables neon intrinsics for apple targets leaving the rest of them untouched. There's probably just a missing flag or something, but someone who actually has the will to compile for aarch64-apple-darwin can maybe figure that out.

@Jake-Shadle
Copy link
Contributor Author

It would probably be good to add CI checking of aarch64-apple-darwin, apple targets are such a pain the ass I never bothered checking AFAIR, I'm fairly sure it has literally never worked, (ie I get the same errors on an outdated clang 13 machine).

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help, it's much appreciated!

A local test showed that it does indeed compile now.

Also, from what I can tell, it already is compiled on all platforms using a matrix, but it's allowed to fail when the CC feature is enabled. Even though warnings are emitted, thus far I admit to not have noticed them.

@Byron Byron merged commit 223f565 into rust-lang:main Dec 6, 2024
48 checks passed
@Jake-Shadle
Copy link
Contributor Author

@Byron
Copy link
Member

Byron commented Dec 6, 2024

That's true!

I wonder if the tests further down run on aarch by default? MacOS in included there and feature is tested, without setting a target specifically.

- run: cargo build --no-default-features --features zlib-ng-no-cmake-experimental-community-maintained || echo "::warning::failed to build libz-ng with --features zlib-ng-no-cmake-experimental-community-maintained"
strategy:
fail-fast: false
matrix:
os:
- windows-2022
- macos-latest
- ubuntu-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants