Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also grep -v out .cargo_vcs_info.json in cargo-zng #217

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

EliahKagan
Copy link
Contributor

Fixes #214

In the cargo-zng script, this has the grep -v command that filters out Cargo.toml.orig also filiter out .cargo_vcs_info.json.

It also refactors the command to use fixed string (-F) and match whole lines (-x), to eliminate the ^ and $ anchors and \ escapes from the pattern(s).

This is working for ./cargo-zng and ./cargo-zng build on Ubuntu 24.04 LTS, macOS 14.6, and Windows 10 in Git Bash.

In addition to `Cargo.toml.orig`.

This also refactors the command to use fixed string (`-F`) and
match whole lines (`-x`), to eliminate the `^` and `$` anchors and
`\` escapes from the pattern.

See rust-lang#214.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, much appreciated!

I particularly like how the grep line has been improved, I had no idea it could do that!.

@Byron Byron merged commit b264657 into rust-lang:main Sep 7, 2024
48 checks passed
@EliahKagan EliahKagan deleted the filter branch September 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In cargo-zng on a recent toolchain, tar fails on .cargo_vcs_info.json
2 participants