-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not check pkg-config when cross-compiling for android #199
Conversation
CI has some network issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a motivation for this change either as commit message, as in-code comment, or a combination of both?
Thank you!
Could you spell out everything in the commit message, like I am 3 years old? |
Currently when compiling for android/haiku target we check pkg-config for zlib then fallback to using shipped zlib, this can cause problems as pkg-config sometimes returns host's zlib. This patch makes it to always use shipped zlib instead of pkg-config one. Signed-off-by: sagudev <[email protected]>
In case commit message is still unclear, you can also edit it yourself (I always |
I really meant the 'please explain it like I am 3' because I wouldn't know how to improve it - it's entirely unclear to me, I have no context. |
But it is ok now? (There was a force push between #199 (comment) and #199 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I understand what's going on now and can confirm that the change makes sense to accomplish this goal (without having tested or otherwise validated it).
Currently when compiling for android/haiku target we check pkg-config
for zlib then fallback to using shipped zlib,
this can cause problems as pkg-config sometimes returns host's zlib.
This patch makes it to always use shipped zlib instead of pkg-config one (moves
target.contains("android")
check before pkg-config check).