cc: Only enable ARM_NEON when in target_feature #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix armv7-unknown-linux-musleabi and arm-unknown-linux-musleabi by only passing in ARM_NEON if that target is enabled. * This was only tested without neon, and *not* tested *with* neon support
Byron
requested changes
May 29, 2024
zng/cc.rs
Outdated
| @@ -311,7 +312,9 @@ pub fn build_zlib_ng(target: &str, compat: bool) { | |||
| } | |||
|
|
|||
| // neon | |||
| cfg.define("ARM_NEON", None); | |||
| if features.contains("neon") { | |||
There was a problem hiding this comment.
Even though right now neon is unique, I am afraid that in future there will be neon-ultra or something like that which might make this a false positive.
Can you try features.split(",").any(|name| name == "neon") instead?
There was a problem hiding this comment.
Sure, fixed with a62591d
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable NEON in the future, I think the following will need to be addressed with adding compiler options: