Check only (no longer test) at the MSRV #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
fix-ci
branch
2 times, most recently
from
ec528d5 to
73e71ff
Compare
|
r? @Kobzol |
tgross35
force-pushed
the
fix-ci
branch
2 times, most recently
from
829403d to
44b9eb4
Compare
Shorten test names and adjust indentation.
Adjust CI so we only run a check the main crate at the MSRV (1.23), running tests only at the MSRV of test dependencies. This allows us to keep CI passing without increasing `glob`'s MSRV to match that of `libc` (which since recently is 1.63.0) or other test dependencies. Additionally, set `rust-version` in Cargo.toml.
tgross35
force-pushed
the
fix-ci
branch
2 times, most recently
from
49f87f8 to
9f4dc31
Compare
|
I also added bumps to the runner versions we are using since it seems like the existing macos-11 jobs aren't getting picked up. |
Also ensure we test both x86 and aarch64 MacOS. To slightly reduce the total number of jobs, only check `beta` on Linux.
|
This no longer changes the MSRV so seems pretty unobjectionable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust CI so we only run a check the main crate at the MSRV (1.23), running tests only at the MSRV of test dependencies. This allows us to keep CI passing without increasing
glob's MSRV to match that oflibc(which since recently is 1.63.0) or other test dependencies.Additionally, set
rust-versionin Cargo.toml.