Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for suspected typo in flexibility.md #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bobulous
Copy link

Corrected what I believe to be copy-pasta in the C-CALLER-CONTROL guideline.

Corrected what I believe to be copy-pasta in the C-CALLER-CONTROL guideline.
@Bobulous Bobulous changed the title Update flexibility.md Fix for suspected typo in flexibility.md Feb 24, 2024
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original wording is intentional. This guideline is discussing functions that do not do anything that needs ownership of the argument, only dealing with the argument by borrow.

Could you find a different way to reword this?

@Bobulous
Copy link
Author

I think the original wording is intentional. This guideline is discussing functions that do not do anything that needs ownership of the argument, only dealing with the argument by borrow.

Could you find a different way to reword this?

Oh, so the original comment means "use b as if it's been borrowed, but take ownership and drop it before function returns"?

I understand now, but I did read it (and re-read it) and think it was a typo. Might just be my brain tripping over it, though. If no one else was baffled by it then it might be fine the way it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants