Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to include debug libs #72

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

msdrigg
Copy link
Contributor

@msdrigg msdrigg commented Oct 5, 2023

  • Adding env and cli flag to control including debug libs (defaulting to false)
  • Updating readme to document the change

- Adding env and cli flag to control including debug libs (defaulting to false)
- Updating readme to document the change
@msdrigg
Copy link
Contributor Author

msdrigg commented Oct 5, 2023

This has been tested and it works for me. I tested both the XWIN_INCLUDE_DEBUG_LIBS=true and --xwin-include-debug-libs methods and both will cause debug libs to be installed.

I also tested with no env vars and no additional flags, and no debug libs were installed.

@msdrigg
Copy link
Contributor Author

msdrigg commented Oct 5, 2023

Solves #71

src/common.rs Outdated Show resolved Hide resolved
@messense messense linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@messense messense enabled auto-merge (squash) October 5, 2023 04:39
@messense messense merged commit a8f471c into rust-cross:main Oct 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link error when using with paho-mqtt. Missing file msvcrtd.lib
2 participants