Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove num-derive dependency #32

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

FreezyLemon
Copy link
Contributor

I checked that the implementation is equivalent with cargo expand.

This change removes syn from the build with default features and reduces compile times by roughly 50% on my machine. I think that's good enough to warrant ~15 lines of boilerplate.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (f0c70fd) to head (4738a3a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   67.22%   68.30%   +1.07%     
==========================================
  Files           4        4              
  Lines         949      978      +29     
==========================================
+ Hits          638      668      +30     
+ Misses        311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FreezyLemon
Copy link
Contributor Author

I guess I should add tests while I'm at it

@lu-zero
Copy link
Member

lu-zero commented Mar 10, 2024

I guess it needs a rebase but looks fine to me.

@FreezyLemon FreezyLemon force-pushed the remove-num-derive-dependency branch from e4b626e to 4738a3a Compare March 10, 2024 20:06
@lu-zero lu-zero merged commit 7eb09fc into rust-av:main Mar 10, 2024
6 checks passed
@FreezyLemon FreezyLemon deleted the remove-num-derive-dependency branch March 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants