Update CI script

[FreezyLemon]

checkout v3 gives some warnings about outdated nodejs.

For dtolnay/rust-toolchain, it's not necessary to specify the toolchain variable when you use dtolnay/rust-toolchain@stable, @nightly etc.

[FreezyLemon]

I missed that the codecov action also needs to be updated. I'll push a commit when I checked the potential breakage

[FreezyLemon]

Looks like we can't update codecov/codecov-action yet:

https://github.com/codecov/codecov-action#breaking-changes:

Breaking Changes

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

Someone would need to setup a token in the Codecov Web UI and set that as a secret for the GH action to use. Maybe in another PR.

That means this PR is done

[Luni-4]

I have added a CODECOV_TOKEN for this repository. Perhaps we can remove the actions to install Rust and use the rustup commands directly, thus reducing the number of dependencies

[FreezyLemon]

Sure, that should be relatively simple. The rust-toolchain action is nice for declaring versions like stable minus 5 releases or something which is cool for MSRV checking and such.

For simple stable/nightly installations, invoking it directly is also a good option. I'll change that in a minute

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24fce24) 66.52% compared to head (5ab548c) 66.52%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files           4        4           
  Lines         923      923           
=======================================
  Hits          614      614           
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FreezyLemon]

Removed the dependency on the toolchain action. This means we now rely on the fact that rustup is already installed, which should be a safe bet for github-hosted runners.

I also tentatively added the codecov-action update, let's hope it works (errors might only show up after merging, which is a bit of a pain)

[FreezyLemon]

This has turned into a bit of a mess.. I'm tempted to go back to the rust-toolchain action, it is way more convenient.

Either way, the PR should be squashed before merging.

[Luni-4]

Ok for turning back to the rust-toolchain action. Can we move the GRCOV_VERSION at the start of the yml file as env variable, so we can control its version directly from there?

[FreezyLemon]

Server error 500. I'll rerun it in a few minutes and hopefully see whether it's a real server error or something I changed.

[FreezyLemon]

Looks like v4 of codecov/codecov-action is unreliable: codecov/codecov-action#1274

I'll roll back to v3 for now.

[FreezyLemon]

Isn't CI fun?

I'll leave the codecov token stuff in for now, might as well get it out of the way.

[Luni-4]

Try to remove fail_ci_if_error option and run v4, let's see what happens, I suspect it might be a spurious problem

[FreezyLemon]

Sure. Not sure that's great either, but I'll try

[Luni-4]

Yee, it worked!

[FreezyLemon]

Of course it works now 🤦
I guess we could not fail the CI when the upload fails, but we should keep in mind that it does fail to upload sometimes. It seems to be a known problem, at least.

[FreezyLemon]

Ah, actually, I think I should roll back the token thing for now. I'll open a PR from a branch on rust-av/v_frame to introduce those changes.

[Luni-4]

Yep, I agree! Approved in advance anyway!