Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve imports in plane.rs #25

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

FreezyLemon
Copy link
Contributor

Two small changes:

  • Remove use std::u32 and use std::usize (there is no reason to import these)
  • Import std::mem::size_of directly instead of just std::mem (other files in the project do the same)

I think the only reason to use std::u32 nowadays would be using the deprecated constants? I think you get to use the integer primitives even when disabling the Rust prelude...

- Remove `use std::u32` and `use std::usize` (there is no reason to import these)
- Import `std::mem::size_of` directly instead of just `std::mem` (other
  files in project do the same)
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0244b29) 66.52% compared to head (b3f7676) 66.52%.

Files Patch % Lines
src/plane.rs 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files           4        4           
  Lines         923      923           
=======================================
  Hits          614      614           
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lu-zero lu-zero merged commit 24fce24 into rust-av:main Feb 20, 2024
3 checks passed
@FreezyLemon FreezyLemon deleted the remove-unneeded-use-statements branch February 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants