-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow including lemmas dynamically into APRProver #4681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a functional rule
…s clause translation for functional rule
…ication rules to konvert
…unctional rules to translate
… tests to working version
…n concrete/symbolic attribute too
tothtamas28
approved these changes
Nov 14, 2024
@@ -255,19 +255,19 @@ def prove_claim( | |||
depth=depth, | |||
) | |||
|
|||
def get_claim_modules( | |||
def parse_modules( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the module parser exposed by kprove
general enough to parse an arbitrary module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm, I think it should be? But I'm not 100% on that.
…tion to avoid issues
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to include lemmas dynamically in the Kontrol prover, we need an option for passing the extra module into the
APRProver
so that it can be fed into the booster'sadd-module
endpoint. This also requires being able to translate functional rules to Kore in pyk usingkrule_to_kore
. This PR:extra_module
parameter to theAPRProver
initialization, which allows passing a new module with lemmas into the prover at initialization time. It will pass this module on to theadd-module
endpoint and make sure it's used on all future requests.symbolic
andsmt-lemma
attributes to the list of attributes recognized by pyk.KProve.get_claims_modules
toKProve.parse_modules
, and renames some of its parameters.bool_to_ml_pred
for converting boolean predicates to matching logic ones._krule_to_kore
to make it support translating some functional/simplification rules to Kore which were not supported before (and adds tests):_krule_att_to_kore
method for converting attributes ofKRule
to kore.krule_to_kore
(eg. handleowise => priority(200)
andsimplification
vspriority
).axiom
to differentiate between semantic and functional rules, and to convert functional rules as matching-logicimplies
axioms.