Add Michelson hooks #104
Merged
Add Michelson hooks #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
reviewed
May 29, 2020
|
Please open PRs into relevant subrepos and link them here @sskeirik . |
Packaged version does not provide needed symbols
Co-authored-by: Everett Hildenbrandt <[email protected]>
sskeirik
force-pushed
the
add_michelson_hooks
branch
from
986cce9
to
50ef816
Compare
|
Finally coming back to this. Since it has been awhile, it is probably helpful to look at the overall plan here: #102. The changes in this PR represent the first phase of the plan laid out in that issue. The linked kevm PR updating the plugin to this commit follows below: |
|
@ehildenb kevm build passed, so this should be ready to review now. Let me know if you have any questions/comments. Thanks! |
|
This LGTM, but I would like @dwightguth 's review as well. |
ehildenb
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First phase of the plugin update.