modified: src/automerge.py #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify api end points used to check status. Previous did not have a permission option with fine-grained tokens. - This reduces permissioni requirements to use automerger
- Update tests to use the new less permissive token.
- Checking the 'chech' statuses per commit - Ccombined commit was not always accurate to the mergeable state of a PR due to annotations and other items checked not important to basic check passed? Approved? Up to datae? Yes? Merge.
tothtamas28
reviewed
Dec 3, 2024
src/automerge.py
Outdated
| all_checks_passed = False | ||
| commit = pr.get_commits().reversed[0] | ||
| statuses = commit.get_statuses() | ||
| all_checks_passed = all(print(status) for status in statuses) |
There was a problem hiding this comment.
This evaluates to False regardless of statuses. (And as a side effect, will print the first status.)
There was a problem hiding this comment.
The tests came back as expected.
https://github.com/runtimeverification/automerge/actions/runs/12061856900/job/33634749102#step:4:1
I'll debug this now. Must be getting a false positive
There was a problem hiding this comment.
Addressed this issue. This required reworking permissions to introduce the use for a Github App.
Remaining is to update the README and docs and tests
- Rework logic. - New dependency for infrastructure to run. Install Github App AutomergePR Permission Control to have access to check statuses. Bug in Github fine-grained tokens or deprecated documentaiton never removed.
- Updating workflow test to use the GH APP credentials modified: README.md - Modifying instructions and informating need for github and what permissions are needed for the github App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits of the Change:
Minimum requirements
