added TCP support for server and client APIs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit incorporates the modified CoAP header for TCP, as defined in https://tools.ietf.org/html/draft-ietf-core-coap-tcp-tls-06.
Short messages would have the incorrect length encoded!
Prior to this change, Message and TcpMessage could not be used interchangeably. Now, Message has been converted to an interface, TcpMessage implements the interface, and the struct previously known as Message is now called DgramMessage.
Add API to set URIQuery to a message
Add API to set Observe option to a message
|
Additional work to be done once/if this PR is merged would be to better align the client and server API's with the net/http package from the stdlib. Ideally, it'd be possible to have go-coap be a drop in replacement for net/http in popular router packages. |
ccollins476ad
force-pushed
the
master
branch
from
47c23e2 to
8e55328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While messageTCP.go handled all of the packet formatting, the client and server API's were tightly coupled to the UDP transport. This commit abstracts the transport with the pre-existing coap.Conn struct and more media types were added including CBOR, OCF and LWM2M