Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the raptor example in llama-index-packs by updating the pip ins… #17354

Merged

Conversation

Riddhimaan-Senapati
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

fixed the raptor example in llama-index-packs by updating the pip installs. I specifically added llama-index-vector-stores-chroma, chromadb (as the example notebook was not able to run without these installs) and --upgrade transformers(It was downloading an old version of transformers which had to be upgraded to 0.21.00). Without these changes, the notebook was not running when I downloaded it.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

There is no new package

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Not required due to minor issue, fixing bugs in example code.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.(Not required due to simply updating pip installs in example code)
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 23, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Riddhimaan-Senapati
Copy link
Contributor Author

@tobi @wpiekutowski @xevo @bborn Can one of you guys review my PR? Excited to begin contributing to this repo.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 23, 2024 16:11
@logan-markewich logan-markewich self-assigned this Dec 23, 2024
@logan-markewich logan-markewich merged commit 9b25d8c into run-llama:main Dec 23, 2024
11 checks passed
@Riddhimaan-Senapati Riddhimaan-Senapati deleted the fix_raptor_example branch December 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants