Cognee integration #17314
Open
Cognee integration #17314
+591
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal for integration of cognee to llama-index
Resolve issue of propagating llm key to cognee in test fix
Added more descriptions to cognee GraphRAG Refactor
Updated README.md docs
…into cognee-integration
Added lint and formatting changes Docs
dosubot
bot
added
the
size:L
There was a problem hiding this comment.
no need to commit the lock file
| graph_db_provider, | ||
| vector_db_provider, | ||
| relational_db_provider, | ||
| db_name, |
There was a problem hiding this comment.
None of these args are typed
| ) | ||
| cognee.config.system_root_directory(cognee_directory_path) | ||
|
|
||
| async def add(self, data, dataset_name: str): |
There was a problem hiding this comment.
Can we add return type annotations, even its its -> None ?
| from .base import GraphRAG | ||
|
|
||
|
|
||
| class CogneeGraphRAG(GraphRAG): |
There was a problem hiding this comment.
Maybe a docstring is needed here
| from llama_index.graph_rag.cognee import CogneeGraphRAG | ||
|
|
||
|
|
||
| async def test_graph_rag_cognee(): |
There was a problem hiding this comment.
These tests will not run in CICD. We probably need to
- mark this as skip if the appropriate API keys are missing
- maybe write tests that mock network calls? Up to you
There was a problem hiding this comment.
Added marking as skipped if API key is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration of the cognee GraphRAG to LlamaIndex.
With added tests, README.md and usage example in README.md
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods