Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add py.typed for OpenAI and Gemini #17295

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

ex0ns
Copy link
Contributor

@ex0ns ex0ns commented Dec 17, 2024

Description

The two packages are missing py.typed which is required for proper type checking by Mypy.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@logan-markewich logan-markewich self-assigned this Dec 17, 2024
@ex0ns
Copy link
Contributor Author

ex0ns commented Dec 18, 2024

Forgot about the Bazel formatting, sorry for that

@logan-markewich logan-markewich enabled auto-merge (squash) December 18, 2024 22:04
@logan-markewich logan-markewich merged commit ef08633 into run-llama:main Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants