Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoyageAI multimodal embedding, correction #17284

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

fzowl
Copy link
Contributor

@fzowl fzowl commented Dec 16, 2024

Description

VoyageAI's multimodal integration was added a few days ago, but i found a bug when i tested it deeper.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests
  • I tested with my test script, based on other examples. I'll add this example in a separate PR

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@fzowl
Copy link
Contributor Author

fzowl commented Dec 16, 2024

@ravi03071991 @logan-markewich Guys, thank you very much merging my previous PR: #17261
I tested that change with a more complete test (i'm going to add this example ipynb file in a separate PR) and found a bug in the previous PR - so i'm correcting it.

Can you please review this change?

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@logan-markewich logan-markewich merged commit 5e9808b into run-llama:main Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants