Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): fixed NDCG calculation and updated previous tests #17236

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

alexeyrodriguez
Copy link
Contributor

@alexeyrodriguez alexeyrodriguez commented Dec 10, 2024

Description

This PR reverts the previous fix to NDCG, which is incorrect, and applies the correct fix.

Fixes #17070 (the previous fix didn't address the issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 10, 2024
@alexeyrodriguez alexeyrodriguez force-pushed the ndcg-fix branch 2 times, most recently from 36eee48 to 9a57dda Compare December 10, 2024 20:22
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 10, 2024 22:54
@logan-markewich logan-markewich self-assigned this Dec 10, 2024
@alexeyrodriguez
Copy link
Contributor Author

@logan-markewich I updated with main, maybe that helps with the failing unit test (which seems unrelated to the changes in this PR)

@logan-markewich
Copy link
Collaborator

yea don't worry about modelscope

@logan-markewich logan-markewich merged commit 21f6e34 into run-llama:main Dec 11, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calculation of ideal DCG in NDCG is incorrect
2 participants