Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trust_remote_code argument, make default = False for other classes #17135

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

Nau-git
Copy link
Contributor

@Nau-git Nau-git commented Dec 3, 2024

Description

Fixes issue with loading rerank model that needs to be loaded using 'trust_remote_code' argument, as stated here #17131

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 3, 2024
@@ -20,6 +20,10 @@ class SentenceTransformerRerank(BaseNodePostprocessor):
default=False,
description="Whether to keep the retrieval score in metadata.",
)
trust_remote_code: bool = Field(
default=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should default to True, seems like a CVE waiting to happen :)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
@logan-markewich logan-markewich changed the title add trust_remote_code argument add trust_remote_code argument, make default = False for other classes Dec 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@logan-markewich
Copy link
Collaborator

Testing failures are unrelated to this PR

@logan-markewich logan-markewich merged commit 112d307 into run-llama:main Dec 4, 2024
7 of 11 checks passed
@Nau-git Nau-git deleted the fix-trust-remote-code branch December 5, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants