Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IS_EMPTY metadata filters to Weaviate Vector Store integration #17128

Merged

Conversation

andrewisplinghoff
Copy link
Contributor

@andrewisplinghoff andrewisplinghoff commented Dec 2, 2024

Description

This allows for using the IS_EMPTY metadata filter also when using a Weaviate Vector Store. This filter was introduced in #15167 and is supposed to filter for objects for which a property is set to null or has an otherwise empty value. The IsNull operator in Weaviate is a good match to what IS_EMPTY is expected to do: https://weaviate.io/developers/weaviate/api/graphql/filters#by-null-state

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@logan-markewich logan-markewich merged commit 867f5e2 into run-llama:main Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants