Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ImageBlock #17111

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat: improve ImageBlock #17111

merged 3 commits into from
Dec 2, 2024

Conversation

masci
Copy link
Member

@masci masci commented Nov 29, 2024

Description

Add proper tests to resolve_image and improve typing for a better UX

Part of #15950

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2024
@masci masci merged commit dad0246 into main Dec 2, 2024
11 checks passed
@masci masci deleted the massi/image-block branch December 2, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants