-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bypass kwargs to SimpeDirectoryReader
with better type hinting
#16858
Open
himself65
wants to merge
14
commits into
run-llama:main
Choose a base branch
from
himself65:himself65/20241106/directory-reader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: bypass kwargs to SimpeDirectoryReader
with better type hinting
#16858
himself65
wants to merge
14
commits into
run-llama:main
from
himself65:himself65/20241106/directory-reader
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himself65
force-pushed
the
himself65/20241106/directory-reader
branch
from
November 6, 2024 21:35
068c260
to
3160214
Compare
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Nov 6, 2024
himself65
changed the title
feat: expose directory args
feat: expose Nov 6, 2024
DirectoryReaderArgs
and LoadFileArgs
himself65
changed the title
feat: expose
feat: bypass kwargs to Nov 6, 2024
DirectoryReaderArgs
and LoadFileArgs
SimpeDirectoryReader
with better type hinting
himself65
force-pushed
the
himself65/20241106/directory-reader
branch
from
November 7, 2024 22:25
bace166
to
0de0b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose args type from SimpleDirectoryReader for downstream file-system like data source
Follow PEP 692, improve type hinting for SimpleDirectoryReader
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods