Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streaming in function calling #16506

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ravi03071991
Copy link
Contributor

Description

PR to add support for streaming in function calling.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 11, 2024
@ravi03071991 ravi03071991 marked this pull request as draft October 11, 2024 13:03
@ravi03071991 ravi03071991 marked this pull request as ready for review October 11, 2024 15:26
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
@ravi03071991 ravi03071991 marked this pull request as draft October 11, 2024 16:10
@chrismgonzalez
Copy link

chrismgonzalez commented Nov 1, 2024

I'm looking to implement function calling streaming into my application. Is this work almost done? Is any assistance needed?

@ravi03071991
Copy link
Contributor Author

I'm looking to implement function calling streaming into my application. Is this work almost done? Is any assistance needed?

There is still work needed here. I will most likely get it done by Wednesday. Will that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants