-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Module Readme Update #16389
LLM Module Readme Update #16389
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hey @logan-markewich 👋 got a big PR for you 😅 |
@@ -27,7 +27,7 @@ exclude = ["**/BUILD"] | |||
license = "MIT" | |||
name = "llama-index-llms-anthropic" | |||
readme = "README.md" | |||
version = "0.3.4" | |||
version = "0.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually don't need to vbump these for README updates -- is it easy to undo these? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yeah for llamahub we don't need to update the version but for PYPI to reflect the new readme update we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through this, and it seems pretty good! (seems like you are able to pull the code samples from the notebooks?)
Yes used the notebook code samples to generate the readme 😄 Initially I was trying to generate the readme using the |
Description
Updated Readme for LLM modules ✅
Done with LLM module, will pick another module in sometime 🤓