Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM Module Readme Update #16389

Merged
merged 5 commits into from
Oct 8, 2024
Merged

LLM Module Readme Update #16389

merged 5 commits into from
Oct 8, 2024

Conversation

anoopshrma
Copy link
Collaborator

@anoopshrma anoopshrma commented Oct 6, 2024

Description

Updated Readme for LLM modules

Done with LLM module, will pick another module in sometime 🤓

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 6, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anoopshrma
Copy link
Collaborator Author

Hey @logan-markewich 👋 got a big PR for you 😅

@@ -27,7 +27,7 @@ exclude = ["**/BUILD"]
license = "MIT"
name = "llama-index-llms-anthropic"
readme = "README.md"
version = "0.3.4"
version = "0.3.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't need to vbump these for README updates -- is it easy to undo these? 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yeah for llamahub we don't need to update the version but for PYPI to reflect the new readme update we do.

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through this, and it seems pretty good! (seems like you are able to pull the code samples from the notebooks?)

@anoopshrma
Copy link
Collaborator Author

Yes used the notebook code samples to generate the readme 😄

Initially I was trying to generate the readme using the base.py but results were not that good in comparison to when I tried with notebooks. So I stick with that 🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@logan-markewich logan-markewich merged commit cae78d5 into run-llama:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants