-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Memgraph integration #16345
Add Memgraph integration #16345
Conversation
llama-index-integrations/graph_stores/llama-index-graph-stores-memgraph/README.md
Outdated
Show resolved
Hide resolved
...stores/llama-index-graph-stores-memgraph/llama_index/graph_stores/memgraph/property_graph.py
Show resolved
Hide resolved
llama-index-integrations/graph_stores/llama-index-graph-stores-memgraph/pyproject.toml
Show resolved
Hide resolved
For unit tests, you'll either need to mock the neo4j client, or use pytest.skipif to skip tests if the client can't connect to neo4j |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @logan-markewich, thank you for the quick response and feedback. I've implemented all of your suggestions, moved a basic usage example to the README file, added a more detailed explanation to the jupyter notebook example for the docs and improved the tests. Let me know if this works, looking forward to the integration :) |
Description
Add Memgraph integration. Extended from the
KnowledgeGraphIndex
andPropertyGraphIndex
class.New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods