Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memgraph integration #16345

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

matea16
Copy link
Contributor

@matea16 matea16 commented Oct 3, 2024

Description

Add Memgraph integration. Extended from the KnowledgeGraphIndex and PropertyGraphIndex class.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 3, 2024
@logan-markewich logan-markewich self-assigned this Oct 3, 2024
@logan-markewich
Copy link
Collaborator

For unit tests, you'll either need to mock the neo4j client, or use pytest.skipif to skip tests if the client can't connect to neo4j

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@matea16
Copy link
Contributor Author

matea16 commented Oct 9, 2024

Hi @logan-markewich, thank you for the quick response and feedback. I've implemented all of your suggestions, moved a basic usage example to the README file, added a more detailed explanation to the jupyter notebook example for the docs and improved the tests. Let me know if this works, looking forward to the integration :)

@logan-markewich logan-markewich merged commit 3c5ac94 into run-llama:main Oct 14, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants